Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed warning (backport #4693) #4702

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Removed warning (backport #4693) #4702

merged 1 commit into from
Apr 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 18, 2024

There is a new warning on CI https://ci.ros2.org/view/packaging/job/packaging_linux/3405/clang-tidy/folder.112366245/

This should fix the warning

This is an automatic backport of pull request #4693 done by Mergify.

@ahcorde @mergify
Removed warning (#4693)
a1b0a62 
* Removed warning

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added suggestions

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 8258507)
@mergify mergify bot mentioned this pull request Apr 18, 2024
Merged
@JesusPoderoso JesusPoderoso added this to the v2.13.5 milestone Apr 18, 2024
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Apr 18, 2024
@JesusPoderoso JesusPoderoso self-requested a review April 18, 2024 07:10
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 18, 2024
JesusPoderoso
JesusPoderoso approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

CI issues unrelated to the PR.
Ready to merge!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels Apr 18, 2024
@EduPonz EduPonz merged commit 47a7691 into 2.13.x Apr 18, 2024
14 of 16 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-4693 branch April 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.13.5
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @EduPonz @ahcorde